Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @oncilla)

a discussion (no related file):
This is serviceable, however, I think we should refine this a bit more. Suggestions:

class ArgsBase:
    # Contains all common arguments

class ConfigGenArgs(ArgsBase):
     # Additionally contains all arguments for the ConfigGen

class TopoGenArgs(ArgsBase):
     # Additionally contains all arguments for the TopoGen

class GoGenArgs(ArgsBase):
     # Additionally contains all arguments for the GoGenerator

...

This way all generators have a consistent interface for their constructor and it's easy to extend with new arguments. For example, the TopoGenerator still takes 5 additional arguments even with your changes. Those 5 could go into TopoGenArgs since this approach works also for non-cmdline flag arguments.

Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @shitz)

a discussion (no related file):

Done.

Reviewed 11 of 11 files at r2.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @shitz and @oncilla)

python/topology/common.py, line 41 at r2 (raw file):

    def __init__(self, args, topo_config):
        """
        :param ArgsBase args: Contains the passed command line arguments.

The args are not of type ArgsBase

python/topology/config.py, line 85 at r2 (raw file):

    @classmethod
    def create_parser(cls):

Putting this here makes it less obvious to find. Just create the parser in main.py and pass the args.

python/topology/config.py, line 129 at r2 (raw file):

        """
        self.args = args
        self.topo_config = load_yaml_file(args.topo_config)

self.args for consistency

python/topology/config.py, line 135 at r2 (raw file):

            sys.exit(1)
        self.default_mtu = None
        self._read_defaults(args.network)

here as well

python/topology/config.py, line 307 at r2 (raw file):

            'RegisterTime': 5,
            'PropagateTime': 5,
            'CertChainVersion': 0,

This never seems to be used, but could you change it to 1? Version 0 doesn't exist as such anymore.

Reviewable status: 4 of 11 files reviewed, 6 unresolved discussions (waiting on @shitz)

python/topology/common.py, line 41 at r2 (raw file):

Done.

python/topology/config.py, line 85 at r2 (raw file):

Done.

python/topology/config.py, line 129 at r2 (raw file):

Done.

python/topology/config.py, line 135 at r2 (raw file):

Done.

python/topology/config.py, line 307 at r2 (raw file):

Done.

Reviewed 7 of 7 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

python/topology/common.py, line 41 at r2 (raw file):

The type is argparse.Namespace